Question: DESeq2 'results' usability issue
gravatar for Gavin Kelly
5 months ago by
Gavin Kelly550
United Kingdom / London / Francis Crick Institute
Gavin Kelly550 wrote:

Debugging someone's code, I just noticed a slight usability issue with the results function, which has a '...' argument, so when results(dds, contrasts=c("group","A","B")) was called, the spelling mistake of the contrast argument wasn't picked up with a usual 'unused argument' warning, and it defaulted to something the user didn't want.  The documentation says that the optional arguments are passed to filterFun, but that no longer looks to be the case in that filterFun takes a specified set of named arguments.

Not a major thing in the grand scheme of things, but if the apparently unused '...' could be removed, it might lessen the chance of similar user error.

ADD COMMENTlink modified 5 months ago by Michael Love17k • written 5 months ago by Gavin Kelly550
gravatar for Michael Love
5 months ago by
Michael Love17k
United States
Michael Love17k wrote:

Thanks for the note, I’ll take a look and if possible make the change in devel.

ADD COMMENTlink written 5 months ago by Michael Love17k

Thanks Gavin, I made this change in devel.

ADD REPLYlink written 5 months ago by Michael Love17k
Please log in to add an answer.


Use of this site constitutes acceptance of our User Agreement and Privacy Policy.
Powered by Biostar version 2.2.0
Traffic: 256 users visited in the last hour