DESeq2 'results' usability issue
1
0
Entering edit mode
Gavin Kelly ▴ 680
@gavin-kelly-6944
Last seen 4.0 years ago
United Kingdom / London / Francis Crick…

Debugging someone's code, I just noticed a slight usability issue with the results function, which has a '...' argument, so when results(dds, contrasts=c("group","A","B")) was called, the spelling mistake of the contrast argument wasn't picked up with a usual 'unused argument' warning, and it defaulted to something the user didn't want.  The documentation says that the optional arguments are passed to filterFun, but that no longer looks to be the case in that filterFun takes a specified set of named arguments.

Not a major thing in the grand scheme of things, but if the apparently unused '...' could be removed, it might lessen the chance of similar user error.

deseq2 • 762 views
ADD COMMENT
2
Entering edit mode
@mikelove
Last seen 14 hours ago
United States

Thanks for the note, I’ll take a look and if possible make the change in devel.

ADD COMMENT
1
Entering edit mode

Thanks Gavin, I made this change in devel.

ADD REPLY

Login before adding your answer.

Traffic: 756 users visited in the last hour
Help About
FAQ
Access RSS
API
Stats

Use of this site constitutes acceptance of our User Agreement and Privacy Policy.

Powered by the version 2.3.6