Bug Report: I think there is a typo in topTags() that interferes with the p.value argument functionality.
1
0
Entering edit mode
@alexandermueting139-12247
Last seen 7.2 years ago

The part of the function that handles p.value is:

    if (p.value < 1) {
        sig <- adj.p.val[o] <= p.value
        sig[is.na(sig)] <- FALSE
        tab <- tab[sig, ]
    }

I think it works as intended if it is adjusted to:

    if (p.value < 1) {

        sig <- tab$PValue <= p.value
        
        sig[is.na(sig)] <- FALSE
        tab <- tab[sig, ]
    }

 

software error edgeR • 595 views
ADD COMMENT
0
Entering edit mode
@gordon-smyth
Last seen 1 hour ago
WEHI, Melbourne, Australia

Dear Alexander,

Thanks for taking the time to make a post, but have you read the document for the topTags function to fully understand what it is intended to do? In order to identify or report a bug, you need to identify an example in which the function doesn't do what it is supposed to do, according to the documentation. You need to actually run the function to show that it gives the wrong answer. Just saying you think that the code should be different without giving a reason isn't the way it works.

Best wishes
Gordon

 

ADD COMMENT

Login before adding your answer.

Traffic: 1076 users visited in the last hour
Help About
FAQ
Access RSS
API
Stats

Use of this site constitutes acceptance of our User Agreement and Privacy Policy.

Powered by the version 2.3.6